Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"invalid peer address" with ipv6 in swarm peer connect #3082

Closed
dokterbob opened this issue Aug 13, 2016 · 6 comments
Closed

"invalid peer address" with ipv6 in swarm peer connect #3082

dokterbob opened this issue Aug 13, 2016 · 6 comments
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog topic/windows Windows specific

Comments

@dokterbob
Copy link
Contributor

dokterbob commented Aug 13, 2016

Version/Platform/Processor information (from ipfs version --all): 0.4.2
Type (bug, feature, meta, test failure, question): bug
Area (api, commands, daemon, fuse, etc): commands
Priority (from P0: functioning, to P4: operations on fire): P2

Description:
Explicitly connecting to peers works fine for ip4 addresses but with ip6 it yields the following result:

$ ipfs swarm peer connect /ip6/<ip6_addr>/tcp/4001/ipfs/<peer_id>
Error: invalid peer address: invalid multiaddr, must begin with /

The error results from /core/commands/swarm.go#L358, the parse error from which originates from thirdparty/ipfsaddr/ipfsaddr.go#L57 which again reaches into go-multiaddr, which seems to be maintained here - and which suggests this is a dependency issue.

However, actually looking at the code it seems this is just a regular string split and something might be fishy about the command argument parser. (This is about as far as I'm willing to follow down this rabbit's hole, for now.)

@ghost ghost added the kind/bug A bug in existing code (including security flaws) label Aug 23, 2016
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Sep 14, 2016
@whyrusleeping whyrusleeping added the status/deferred Conscious decision to pause or backlog label Nov 28, 2016
@whyrusleeping
Copy link
Member

whyrusleeping commented Mar 6, 2017

@lgierth wanna see if you can figure this one out?

@victorb
Copy link
Member

victorb commented Jun 30, 2017

Might be related to using go-ipfs on windows, see https://discuss.ipfs.io/t/ipfs-swarm-connect-command-returns-an-error/696/7

Also another related issue: #3296

@ghost
Copy link

ghost commented Jun 30, 2017

I mean, it would be useful to see the actual multiaddr that caused this error ;)

@victorb
Copy link
Member

victorb commented Jun 30, 2017

@lgierth it seems related to the environment and / rather than the actual IP/port in the multiaddr.

@Kubuxu Kubuxu added the topic/windows Windows specific label Jul 1, 2017
@whyrusleeping
Copy link
Member

whyrusleeping commented Sep 3, 2017

Ah yeah, as @Kubuxu labeled, this is a problem with arguments starting with '/' in windows. ref #4190

@Kubuxu
Copy link
Member

Kubuxu commented Sep 3, 2017

Closing in favour of #4190.

@Kubuxu Kubuxu closed this as completed Sep 3, 2017
@momack2 momack2 added this to Backlog in ipfs/go-ipfs May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog topic/windows Windows specific
Projects
No open projects
Development

No branches or pull requests

4 participants