Set Cache-Control immutable #2672
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that /ipfs/ resources never change, we can easily benefit from this new cache control extension. Support for this is about to land in Firefox 49: https://bugzilla.mozilla.org/show_bug.cgi?id=1267474 For more details, there is a good blogpost about this here: https://bitsup.blogspot.de/2016/05/cache-control-immutable.html This header is ignored by clients that don't support it. License: MIT Signed-off-by: kpcyrd <git@rxv.cc>
kpcyrd
force-pushed
the
feature/cache-control-immutable
branch
from
f64793a
to
c2a3e31
Compare
|
LGTM, It doesn't seem like anyone is using it yet but it seems like a good idea. |
|
LGTM, this is really interesting stuff |
|
Heads up: Firefox is shipping support in 49 \o/ https://developer.mozilla.org/en-US/Firefox/Releases/49#HTTP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Given that /ipfs/ resources never change, we can easily benefit from this new cache control extension.
Support for this is about to land in Firefox 49:
https://bugzilla.mozilla.org/show_bug.cgi?id=1267474
For more details, there is a good blogpost about this here:
https://bitsup.blogspot.de/2016/05/cache-control-immutable.html
This header is ignored by clients that don't support it.