Expose Content-Range header #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Content-Range` header is necessary for extracting (only) the metadata of audio files. License: MIT Signed-off-by: Steven Vandevelde <icid.asset@gmail.com>
|
FYI, it appears that tests are randomly failing, not sure why. |
|
LGTM, but I would like to make sure with @lgierth |
|
Friendly reminder |
16 tasks
|
Sorry -- this LGTM |
ghost
approved these changes
Jul 30, 2017
|
This has two |
|
@flyingzumwalt @whyrusleeping is the only one that merges to go-ipfs |
|
Friendly reminder @whyrusleeping |
|
@icidasset sorry for the delay! Would love to check out your app when its ready :) |
|
@whyrusleeping Thanks! Will post again on the IPFS forums when it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The
Content-Rangeheader is necessary for extracting (only) the metadata of audio files.License: MIT
Signed-off-by: Steven Vandevelde icid.asset@gmail.com