fix defered unlock of pin lock in AddR #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't causing any problems because this function is actually dead code (but possibly useful?). License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned 
|
I would say to remove it, but it is exported so it could conceivable be used by another package outside of go-ipfs. I think we have a lot of dead code like this. @Kubuxu (or anyone else) is there a way to detect all unused exported functions in go-ipfs? |
ghost
approved these changes
Jan 8, 2018
Thanks!
I'd like to remove all these Add*() util funcs once the Core API is fully ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This wasn't causing any problems because this function is actually dead code (but possibly useful?).
Should we just remove this function?