add: Fix adding multiple files #6255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
ghost
assigned 
Stebalien
approved these changes
Apr 25, 2019
LGTM. I'd like to reconsider how we're doing events (ideally, we'd be able to reuse the channel) but we can handle that in a followup PR.
| _, dir := addit.Node().(files.Directory) | ||
| errCh := make(chan error, 1) | ||
| events := make(chan interface{}, adderOutChanSize) | ||
| opts[len(opts)-1] = options.Unixfs.Events(events) |
There was a problem hiding this comment.
Maybe we shouldn't be closing this channel?
There was a problem hiding this comment.
Otherwise, we could drop the need for the nil option by writing:
opts := append(opts, options.Unixfs.Events(events)) // note the :=
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See #6254