Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unixfs): use cidv1 by default #8886

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schomatis
Copy link
Contributor

Toward #4143. Consumes dependency upgrade ipfs/go-unixfs#119.

@lidel Take a look at this change to see if it satisfies the CIDv1 upgrade for ipfs files and ipfs init. There's nothing in this PR but the upgrade in UnixFS. I think the ultimate solution is landing ipfs/go-merkledag#86, but this makes a small modification in the middle layer of UnixFS to set a CIDv1 by default without much propagating big changes.

I'm punting on fixing sharness until I have the modifications for the rest of the commands as I'll likely need to write a small script to parse CIDv0 and upgrade to CIDv1 all over those files. This is just a request for a manual test here and a code review in the dependency upgrade to see if I'm going in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🔎 In Review
Development

Successfully merging this pull request may close these issues.

1 participant