add multicodecs list to libp2p spec #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | multiplex | /multiplex/6.7.0 | | ||
| | spdy | /spdy/3.1.0 | | ||
| | dht | /ipfs/dht/1.0.0 | | ||
| | bitswap | /ipfs/bitswap/1.0.0 | |
There was a problem hiding this comment.
@whyrusleeping found:
exchange/bitswap/network/interface.go
11:var ProtocolBitswap protocol.ID = "/ipfs/bitswap"
Any reason to not have a version?
There was a problem hiding this comment.
Hrm... that appears to be a typo. I remember making a commit where I added versions to this, diag and the dht. Where did that go?
| | yamux | /yamux/1.0.0 | | ||
| | multiplex | /multiplex/6.7.0 | | ||
| | spdy | /spdy/3.1.0 | | ||
| | dht | /ipfs/dht/1.0.0 | |
There was a problem hiding this comment.
Missing semver
routing/dht/dht.go
32:var ProtocolDHT protocol.ID = "/ipfs/dht"
|
@whyrusleeping could you confirm this list and see if I also missed a protocol? |
|
@whyrusleeping I've updated these according to the gist. Is it good to update the ones in go to also use semver? |
This was referenced Apr 18, 2016
| relay | /ipfs/relay/line/1.0.0 | ||
| diagnostics | /ipfs/diag/net/1.0.0 | ||
| Kademlia DHT | /ipfs/kad/1.0.0 | ||
| bitswap | /ipfs/bitswap/1.0.0 |
There was a problem hiding this comment.
@whyrusleeping can you ping me here when you get to merge the double handlers on go-ipfs to support the version with semver? thank you :)
//cc @dignifiedquire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing these down in the spec so that we agree and don't loose them again.