Skip to content
Permalink
Browse files

fix makefile: explicitly set bash as shell; tune lint. (#706)

* fix makefile: explicitly set bash as shell; tune lint.

* unquote SHELL.

* downgrade golangci-lint to v1.23.6.

v1.24.0 has memory usage regressions: golangci/golangci-lint#994
  • Loading branch information
raulk committed Mar 18, 2020
1 parent 395e8bd commit ef5694ccbe6270f7a7dd42d66965ad1ec322883f
Showing with 3 additions and 2 deletions.
  1. +1 −1 .travis.yml
  2. +2 −1 Makefile
@@ -40,7 +40,7 @@ jobs:
- git diff --exit-code
- go mod download
- echo 'travis_fold:start:go.mod.graph' && echo 'go mod graph' && go mod graph && echo 'travis_fold:end:go.mod.graph'
- pushd .. && go get github.com/golangci/golangci-lint/cmd/golangci-lint && popd
- pushd .. && go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.23.6 && popd
- make lint # run a bunch of code checkers/linters in parallel
- make test-build # build the project
- make test # Run all the tests with the race detector enabled
@@ -1,4 +1,5 @@
GOTFLATS ?=
SHELL = /bin/bash

define eachmod
@echo '$(1)'
@@ -16,7 +17,7 @@ tidy:
$(call eachmod,go mod tidy)

lint:
$(call eachmod,golangci-lint run ./...)
$(call eachmod,GOGC=75 golangci-lint run --concurrency 32 --deadline 4m ./...)

test-build:
$(call eachmod,go build -o /dev/null ./...)

0 comments on commit ef5694c

Please sign in to comment.
You can’t perform that action at this time.