Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitswap test suite #345

Merged
merged 14 commits into from Feb 13, 2020
Merged

Add bitswap test suite #345

merged 14 commits into from Feb 13, 2020

Conversation

@dirkmc
Copy link
Collaborator

dirkmc commented Jan 15, 2020

This PR contains test suites that

  • run testground with several combinations of seeds and leeches, measuring the performance (time to fetch, duplicate blocks) at different latency / bandwidth for varying file size.
    Results: ipfs/go-ipfs#6782
  • run testground with 1 leech / 3 seeds (100ms / 500ms / 1000ms latency) to test that Bitswap favours lower latency seeds.
    Results: #436
@dirkmc dirkmc force-pushed the feat/bitswap-test-suite branch from a5ce59f to f223a49 Feb 5, 2020
@dirkmc dirkmc marked this pull request as ready for review Feb 6, 2020
@Stebalien

This comment has been minimized.

Copy link
Contributor

Stebalien commented Feb 13, 2020

@dirkmc we can probably rebase and land this, right?

@dirkmc

This comment has been minimized.

Copy link
Collaborator Author

dirkmc commented Feb 13, 2020

Yes, it's just been waiting for review - I will rebase and ping you

@dirkmc dirkmc force-pushed the feat/bitswap-test-suite branch from e3e48dd to c1f754f Feb 13, 2020
@dirkmc

This comment has been minimized.

Copy link
Collaborator Author

dirkmc commented Feb 13, 2020

@Stebalien I rebased so this is now mergeable - I have another branch that depends on this one that also cleans up some of the code, so if there's nothing major I'd suggest we merge and then refactor

@Stebalien Stebalien force-pushed the feat/bitswap-test-suite branch from da297a1 to f0668f2 Feb 13, 2020
@Stebalien

This comment has been minimized.

Copy link
Contributor

Stebalien commented Feb 13, 2020

Yeah, this PR just touches the test plan so I'm not concerned about potential issues.

@Stebalien Stebalien force-pushed the feat/bitswap-test-suite branch from ccde3c9 to 7e3c773 Feb 13, 2020
@Stebalien

This comment has been minimized.

Copy link
Contributor

Stebalien commented Feb 13, 2020

I fixed the lints to get CI passing.

@Stebalien Stebalien force-pushed the feat/bitswap-test-suite branch from 7e3c773 to 519a144 Feb 13, 2020
@Stebalien Stebalien force-pushed the feat/bitswap-test-suite branch from 519a144 to b1f6c66 Feb 13, 2020
@Stebalien Stebalien merged commit 212d870 into master Feb 13, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.