Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: terminate command and interfaces #559

Merged
merged 1 commit into from Feb 14, 2020
Merged

feat: terminate command and interfaces #559

merged 1 commit into from Feb 14, 2020

Conversation

@hacdias
Copy link
Member

hacdias commented Feb 14, 2020

This is related to #432 and adds the terminate command and the Terminatable interface.

I decided to do this on smaller PRs.

On this PR:

  • A single-method interface Terminatable: TerminateAll() error that runners supporting termination can implement.

What's missing to do on separate PRs:

  • Implement TerminateAll() error for each runner.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias requested review from nonsense and raulk Feb 14, 2020
@hacdias hacdias self-assigned this Feb 14, 2020
@hacdias hacdias linked an issue that may be closed by this pull request Feb 14, 2020
@hacdias hacdias merged commit 762d303 into master Feb 14, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@hacdias hacdias deleted the feat/terminatable branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.