Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement manual build selectors, wired to build tags in go builders. #566

Merged
merged 6 commits into from Feb 28, 2020

Conversation

@raulk
Copy link
Member

raulk commented Feb 16, 2020

This implements manual shim selection as specified in #565.

Users can now set build tags to be applied when building group artifacts, in the form of build selectors. The docker:go and exec:go builders map these build selectors to go build tags (-tags).

This feature makes it possible to write wildcard test plans that compile and work against multiple versions of upstream dependencies where API changes are introduced.


TODO:

  • write unit tests.
This implements manual shim selection as specified in
the docs/EVOLVING_APIs.md specification. Users can now
set build tags to be applied when building group artifacts.
raulk added 2 commits Feb 20, 2020
@raulk raulk marked this pull request as ready for review Feb 20, 2020
@nonsense

This comment has been minimized.

Copy link
Member

nonsense commented Feb 20, 2020

lgtm

@raulk

This comment has been minimized.

Copy link
Member Author

raulk commented Feb 27, 2020

Tests succeeded in the branch job, failed in the PR job; there's some flakiness here.

@raulk

This comment has been minimized.

Copy link
Member Author

raulk commented Feb 27, 2020

Tests succeeded now; but linting is timing out 🤷‍♂

@raulk raulk merged commit cf00c1b into master Feb 28, 2020
0 of 2 checks passed
0 of 2 checks passed
Travis CI - Branch Build Failed
Details
Travis CI - Pull Request Build Failed
Details
@raulk raulk deleted the feat/build-selectors branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.