Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix makefile: explicitly set bash as shell; tune lint. #706

Merged
merged 3 commits into from Mar 18, 2020
Merged

Conversation

@raulk
Copy link
Member

raulk commented Mar 18, 2020

Hopefully these changes will fix our linting woes on CI.

raulk added 2 commits Mar 18, 2020
@raulk raulk force-pushed the fix/makefile branch from 86dc661 to 2dd786b Mar 18, 2020
v1.24.0 has memory usage regressions: golangci/golangci-lint#994
@raulk raulk merged commit ef5694c into master Mar 18, 2020
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Failed
Details
Travis CI - Branch Build Passed
Details
@raulk raulk deleted the fix/makefile branch Mar 18, 2020
@Robmat05 Robmat05 added the kind/bug label Mar 18, 2020
@Robmat05 Robmat05 added this to the Testground v0.4 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.