Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
harden redis and sync service. #712
additionally: harden throttling logic in local:docker runner.
* increase default sync service redis pool size from runtime.NumCPU()*10 to 8192 to prevent starvation. Starvation is very probable given that we use the XREAD primitive, which blocks a connection. The sidecar is especially exposed to this, as it is a single process that accumulates a lot of XREAD blocked conns to receive network change requests from instances. 8192 is a suitable value because on local:docker, we won't run as many containers, and on cluster:k8s, sidecars only handle containers colocated on the node. * increase ulimits on infra containers to 1M open file descriptors. * expose pprof port of sidecar; enable GC traces for debuggability. * upgrade to go-redis v7.2.0. additionally: harden throttling logic in local:docker runner.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.