From e7ed3af3c051db9f86ab02f3afe5bfd9ecfa7090 Mon Sep 17 00:00:00 2001 From: LI Daobing Date: Tue, 30 Jan 2018 20:24:14 +0800 Subject: [PATCH 1/2] add warn when setsockopt --- src/iptux/support.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/iptux/support.cpp b/src/iptux/support.cpp index 39469477..a3dbb45b 100644 --- a/src/iptux/support.cpp +++ b/src/iptux/support.cpp @@ -304,7 +304,9 @@ void socket_enable_broadcast(int sock) { optval = 1; len = sizeof(optval); - setsockopt(sock, SOL_SOCKET, SO_BROADCAST, &optval, len); + if(setsockopt(sock, SOL_SOCKET, SO_BROADCAST, &optval, len) != 0) { + LOG_WARN("setsockopt for SO_BROADCAST failed: %s", strerror(errno)); + } } /** @@ -317,7 +319,9 @@ void socket_enable_reuse(int sock) { optval = 1; len = sizeof(optval); - setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &optval, len); + if(setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &optval, len) != 0) { + LOG_WARN("setsockopt for SO_REUSEADDR failed: %s", strerror(errno)); + } } /** From f8081a646e52f85ceadecb62e96590b35af62d50 Mon Sep 17 00:00:00 2001 From: LI Daobing Date: Tue, 30 Jan 2018 20:33:56 +0800 Subject: [PATCH 2/2] update NEWS --- NEWS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.md b/NEWS.md index 4c54a1b5..71e53b45 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,7 @@ # 0.7.5 (2018-XX-XX) * [#114] fix icon size. +* [#119] check the return code of `setsockopt`. # 0.7.4 (2018-01-24)