Roll back f7710a1 which checks payloads incorrectly, ignores all mism… #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atch replies - gather_statistics() already checks payloads and reports truncated packets - f7710a1 skips all payload comparisons in gather_statistics() when it should not - f7710a1 ignores truncated packets when it should not - f7710a1 broke ping's historical behavior that reply payloads are checked against request payloads and differences (including reply truncation) are reported by gather_statistics(), because the change prevents execution of gather_statistics() entirely unless payload match is complete and the reply is not truncated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atch replies
against request payloads and differences (including reply truncation) are
reported by gather_statistics(), because the change prevents execution of
gather_statistics() entirely unless payload match is complete and the reply
is not truncated