Skip to content
Permalink
Browse files
[ifmgmt] Do not sleep CPU while configuring network devices
iPXE currently calls cpu_nap() while performing DHCP, in order to
reduce CPU utilisation on virtual machines.  Under mild broadcast load
(~100 packets per second), this can cause received packets to be
dropped because the receive descriptor ring is overrun before the next
18Hz timer interrupt wakes up the CPU.  The result is that DHCP is
likely to intermittently fail on networks with appreciable amounts of
broadcast (or multicast) traffic.

This behaviour was introduced in the series of commits which
generalised the "dhcp" command to the "ifconf" command.  The earlier
code (which did not handle IPv6 configuration) had no call to
cpu_nap() and so did not suffer from this problem.

Fix by removing the call to cpu_nap() in ifpoller_progress().  This
has the undesirable side effect that CPU utilisation will remain at
100% while waiting for DHCP to complete (which can take several
seconds, if we have to wait around for potential ProxyDHCP offers to
arrive).

Reported-by: Alex Davies <adavies@jumptrading.com>
Reported-by: Christoffer Stokbæk <christoffers@easyspeedy.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
  • Loading branch information
mcb30 committed Jun 1, 2014
1 parent f3d423b commit 9f0b7f428af04d0c5ddda78f9b034625f2f91831
Showing 1 changed file with 0 additions and 4 deletions.
@@ -28,7 +28,6 @@ FILE_LICENCE ( GPL2_OR_LATER );
#include <ipxe/device.h>
#include <ipxe/job.h>
#include <ipxe/monojob.h>
#include <ipxe/nap.h>
#include <ipxe/timer.h>
#include <usr/ifmgmt.h>

@@ -142,9 +141,6 @@ struct ifpoller {
static int ifpoller_progress ( struct ifpoller *ifpoller,
struct job_progress *progress __unused ) {

/* Reduce CPU utilisation */
cpu_nap();

/* Hand off to current progress checker */
return ifpoller->progress ( ifpoller );
}

0 comments on commit 9f0b7f4

Please sign in to comment.