Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[realtek] Use ID word to detect EEPROM presence
Some onboard RTL8169 NICs seem to leave the EEPROM pins disconnected. The existing is_valid_ether_addr() test will not necessarily catch this, since it expects a missing EEPROM to show up as a MAC address of 00:00:00:00:00:00 or ff:ff:ff:ff:ff:ff. When the EEPROM pins are floating the MAC address may read as e.g. 00:00:00:00:0f:00, which will not be detected as invalid. Check the ID word in the first two bytes of the EEPROM (which should have the value 0x8129 for all RTL8139 and RTL8169 chips), and use this to determine whether or not an EEPROM is present. Reported-by: Carl Karsten <email@example.com> Tested-by: Carl Karsten <firstname.lastname@example.org> Signed-off-by: Michael Brown <email@example.com>
- Loading branch information
Showing with 42 additions and 16 deletions.