Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override iso build date with SOURCE_DATE_EPOCH #252

Closed
wants to merge 1 commit into from

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Feb 10, 2021

Allow to override iso build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This date call works with GNU date and FreeBSD/MacOSX date.

@mcb30
Copy link
Member

mcb30 commented Feb 12, 2021

Thanks. I think it probably makes sense to check for SOURCE_DATE_EPOCH and, if set, append the arguments to ISOARGS. The existing logic will then take care of choosing a mkisofs equivalent that is capable of support those arguments. In particular, this would mean that a system with both genisoimage and xorrisofs installed would choose xorrisofs when SOURCE_DATE_EPOCH was specified.

Please do include the ability to use BSD date as per https://reproducible-builds.org/docs/source-date-epoch/

Also: a UEFI .iso image will include an embedded FAT filesystem: does genfsimg need to also do something to set the relevant timestamps within this?

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This date call works with GNU date and BSD date.

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
@bmwiedemann
Copy link
Contributor Author

I updated the PR to incorporate the improvements. It makes ipxe.iso reproducible for me, so I would consider UEFI out-of-scope for now.

@mcb30
Copy link
Member

mcb30 commented May 24, 2021

Merged with modifications as 0d68d7151. For me, this still left the isohybrid MBR ID as non-deterministic: this is addressed in 74c54461c

@mcb30 mcb30 closed this May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants