New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExecuteTime.js for IPython 3.x #201

Merged
merged 1 commit into from Mar 22, 2015

Conversation

Projects
None yet
2 participants
@lucasb-eyer
Contributor

lucasb-eyer commented Mar 19, 2015

I had to make these changes in order to get this extension to work for me. I'm using a very recent 3.x version of IPython. Please review carefully, as this is the first time I am touching any IPynb extension code!

I hope the require.toUrl part will work for everyone, because I did install this extension manually.

@juhasch

View changes

Show outdated Hide outdated usability/execute_time/ExecuteTime.js Outdated
@juhasch

View changes

Show outdated Hide outdated usability/execute_time/ExecuteTime.js Outdated
@lucasb-eyer

This comment has been minimized.

Show comment
Hide comment
@lucasb-eyer

lucasb-eyer Mar 21, 2015

Contributor

Amended your suggestions and tested them.

Contributor

lucasb-eyer commented Mar 21, 2015

Amended your suggestions and tested them.

juhasch added a commit that referenced this pull request Mar 22, 2015

Merge pull request #201 from lucasb-eyer/master
Update ExecuteTime.js for IPython 3.x

@juhasch juhasch merged commit 3dbcf5a into ipython-contrib:3.x Mar 22, 2015

@juhasch

This comment has been minimized.

Show comment
Hide comment
@juhasch

juhasch Mar 22, 2015

Member

LGTM. Thanks.

Member

juhasch commented Mar 22, 2015

LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment