New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support transient field, update_display_data #204

Merged
merged 1 commit into from Nov 18, 2016

Conversation

Projects
None yet
2 participants
@minrk
Copy link
Member

minrk commented Nov 8, 2016

API addition:

DisplayPublisher.publish accepts two new keyword-args: update: bool, transient: dict (new args, fully backward-compatible).

Message spec:

adds third transient dict next to data, metadata for data that shouldn't be persisted as part of files.

display_id will be added to this this transient dict by display(obj, display_id=...)

IPython PR: ipython/ipython#10048

This is the ipykernel piece of jupyter/jupyter_client#209

cc @rgbkrk

@rgbkrk

rgbkrk approved these changes Nov 8, 2016

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Nov 9, 2016

I've got an initial implementation that I'll start writing tests for in nteract and evaluating the implementation with direct action mocks. Looking forward to trying this out with the IPython kernel.

nteract/nteract#1162

@minrk minrk added this to the 4.6 milestone Nov 16, 2016

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Nov 16, 2016

What do you think the order of merging and shipping this + ipython/ipython#10048 is?

@minrk minrk changed the title [WIP] support transient field, update_display_data support transient field, update_display_data Nov 18, 2016

@minrk

This comment has been minimized.

Copy link
Member

minrk commented Nov 18, 2016

This one can go first, but I'll make sure that IPython behaves gracefully with ipykernel stable, so release order shouldn't matter too much. The main question that's relevant to both is deciding on the new signature for DisplayPublisher.publish, which is a common API in both packages.

This should be good to go now, in fact.

@rgbkrk rgbkrk merged commit 99bfb03 into ipython:master Nov 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@minrk minrk deleted the minrk:update-display-data branch Nov 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment