New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog for 4.7 release #255
Conversation
Oh, looking closer I see that it still falls back to the old mechanism if it can't import the new one. But should the fact that it's importing |
Seems like yes. Importing this suggests that provisionalcompleter is a semi-public API of IPython that won't change. Is that true? If it's not and the upstream API is indeed provisional, I think we need error handling other than ImportError, and possibly a manual disable flag. |
Basically
|
I'll make a PR with a disable flag, but I don't want to ignore errors or we wont' get potential bug reports. |
If we're satisfied that it won't change, should we call it something else? I understand 'provisional' to mean 'this might change'. I'm not too worried about accidentally exposing it from ipykernel, my concern is more that it looks like ipykernel is using a new not-really-public API from IPython. |
The not really stable API is So
|
@takluyver yup! go for it. I still don't fully understand what's provisional about the provisional APIs, but 👍 to shipping what we have. |
cc @gnestor @Carreau @minrk