New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ipython/ipynb#31 #34

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
3 participants
@blairhudson
Contributor

blairhudson commented Sep 16, 2017

Fixes bug interpreting tuple based assignment.

Example:

a, b = fn()

Previously this would result in the error described in ipython/ipynb#31. This fix correctly parses tuple based assignments as intended.

@ebraminio

This comment has been minimized.

Show comment
Hide comment
@ebraminio

ebraminio Sep 17, 2017

Hi @blairhudson, it seems your patch fixes #35 also. It runs os.environ['a'] = 'b' and O['a'] = 'a' but raises error on o = {}; o['a'] = 'a' (as it seems it leaves the first line but executes subscript), now that you are here, I guess you can fix that also if you are interested of course.

ebraminio commented Sep 17, 2017

Hi @blairhudson, it seems your patch fixes #35 also. It runs os.environ['a'] = 'b' and O['a'] = 'a' but raises error on o = {}; o['a'] = 'a' (as it seems it leaves the first line but executes subscript), now that you are here, I guess you can fix that also if you are interested of course.

@yuvipanda yuvipanda merged commit aae209f into ipython:master Sep 18, 2017

3 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 85.38% (+0%) compared to d0c8988
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yuvipanda

This comment has been minimized.

Show comment
Hide comment
@yuvipanda

yuvipanda Sep 18, 2017

Member

Thank you very much for the patch! I'm swamped with other stuff rn and haven't been able to devote much time to this specific wonderful project, but ill happily merge PRs!

Member

yuvipanda commented Sep 18, 2017

Thank you very much for the patch! I'm swamped with other stuff rn and haven't been able to devote much time to this specific wonderful project, but ill happily merge PRs!

blairhudson added a commit to blairhudson/ipynb that referenced this pull request Sep 19, 2017

@blairhudson

This comment has been minimized.

Show comment
Hide comment
@blairhudson

blairhudson Sep 19, 2017

Contributor

Thanks @yuvipanda @ebraminio. Glad to contribute!

One more PR to fix the problem @ebraminio mentioned above: #36

😄

Contributor

blairhudson commented Sep 19, 2017

Thanks @yuvipanda @ebraminio. Glad to contribute!

One more PR to fix the problem @ebraminio mentioned above: #36

😄

yuvipanda added a commit that referenced this pull request Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment