From 1e79c167a41d13eee673b8bb54798cb2f920f957 Mon Sep 17 00:00:00 2001 From: Diego Fernandez Date: Thu, 26 Mar 2020 14:07:22 -0600 Subject: [PATCH] Bump jedi to at least 0.16.0 and fix deprecated function usage --- IPython/core/completer.py | 5 +++-- setup.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/IPython/core/completer.py b/IPython/core/completer.py index 985ac5ab9eb..fd3939f1e18 100644 --- a/IPython/core/completer.py +++ b/IPython/core/completer.py @@ -988,7 +988,8 @@ def _make_signature(completion)-> str: """ - return '(%s)'% ', '.join([f for f in (_formatparamchildren(p) for p in completion.params) if f]) + return '(%s)'% ', '.join([f for f in (_formatparamchildren(p) for signature in completion.get_signatures() + for p in signature.defined_names()) if f]) class IPCompleter(Completer): """Extension of the completer class with IPython-specific features""" @@ -1398,7 +1399,7 @@ def _jedi_matches(self, cursor_column:int, cursor_line:int, text:str): if not try_jedi: return [] try: - return filter(completion_filter, interpreter.completions()) + return filter(completion_filter, interpreter.complete()) except Exception as e: if self.debug: return [_FakeJediCompletion('Oops Jedi has crashed, please report a bug with the following:\n"""\n%s\ns"""' % (e))] diff --git a/setup.py b/setup.py index 252fe11fa3d..9ec67cb7c8e 100755 --- a/setup.py +++ b/setup.py @@ -184,7 +184,7 @@ install_requires = [ 'setuptools>=18.5', - 'jedi>=0.10', + 'jedi>=0.16', 'decorator', 'pickleshare', 'traitlets>=4.2',