Permalink
Browse files

Check for .pyd as extension for binary files.

Closes gh-497
  • Loading branch information...
1 parent 657504e commit 3902dd419107f14ca6afdfd6d67c0ed357a85224 @takluyver takluyver committed Jun 2, 2011
Showing with 1 addition and 1 deletion.
  1. +1 −1 IPython/core/oinspect.py
@@ -549,7 +549,7 @@ def info(self, obj, oname='', formatter=None, info=None, detail_level=0):
fname = inspect.getabsfile(obj.__class__)
if fname.endswith('<string>'):
fname = 'Dynamically generated function. No source code available.'
- if (fname.endswith('.so') or fname.endswith('.dll')):
+ if any(fname.endswith(e) for e in ['.so', '.dll', '.pyd']):
binary_file = True
out['file'] = fname
except:

5 comments on commit 3902dd4

@ilanschnell

This can be simplified: "if fname.endswith(('.so', '.dll', '.pyd')):"

@fperez
Member
fperez commented on 3902dd4 Jun 7, 2011

Thanks, Ilan! I had never noticed this form of endswith. Excellent. Worth noting that line 360 of the smae file has the same pattern also, so it should probably be fixed there too.

@takluyver
Member

I didn't know about that, either. Thanks. I've updated both checks - see commit 29fa173.

@ilanschnell

You're welcome. I just check this feature was added in Python 2.5, so it's OK because ipython does not support Python 2.4 anymore.

@takluyver
Member

Yep, I checked that, too. In fact, for 0.11, we're only supporting Python 2.6 and above.

Please sign in to comment.