shouldn't we run the build on windows as well? #10116

Closed
srinivasreddy opened this Issue Jan 4, 2017 · 7 comments

Projects

None yet

4 participants

@srinivasreddy
Contributor
srinivasreddy commented Jan 4, 2017 edited
@srinivasreddy srinivasreddy changed the title from shouldn to shouldn't we run the build on windows as well? Jan 4, 2017
@minrk
Member
minrk commented Jan 4, 2017

Now that AppVeyor is a thing, it's worth doing. Would you like to explore adding appveyor configuration?

@srinivasreddy
Contributor

yes

@takluyver
Member

@srinivasreddy I've just noticed that while Appveyor is running on an impressive 8 Python installations, it runs python -c 'True', which is perhaps not the most rigorous test of our code. ;-) Want to make it run the tests as well?

@takluyver takluyver added this to the 6.0 milestone Jan 12, 2017
@takluyver
Member

Also, it currently installs IPython from PyPI, not from the checkout it needs to be testing.

@Carreau
Member
Carreau commented Jan 12, 2017

python -c 'True'

I did that as appveyor was configured and test were not passing, so it was failing everywhere. (it was using nosetest instead of iptest at least).

This was not to block other PR on waiting the testing on Appveyor worked. @srinivasreddy may have missed that on the other PR.

@takluyver
Member

Ah, OK, sorry for wrongly pointing the finger. Let's get it running the tests, anyway.

@takluyver
Member

Fixed by #10164

@takluyver takluyver closed this Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment