namespace changes broke `foo.*bar*?` syntax #1076

Closed
fperez opened this Issue Dec 1, 2011 · 4 comments

Projects

None yet

3 participants

@fperez
Member
fperez commented Dec 1, 2011

On master we now have:

In [2]: sys.*pt*?
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/home/fperez/usr/lib/python2.7/site-packages/IPython/core/oinspect.pyc in psearch(self, pattern, ns_table, ns_search, ignore_case, show_all)
    760             if name not in ns_table:
    761                 raise ValueError('invalid namespace <%s>. Valid names: %s' %
--> 762                                  (name,ns_table.keys()))
    763 
    764         #print 'type_pattern:',type_pattern # dbg


ValueError: invalid namespace <user>. Valid names: ['alias', 'user_global', 'builtin', 'user_local']

We should add a test for this form of call before fixing it, so that we're sure the bug doesn't come back.

@minrk
Member
minrk commented Dec 1, 2011

Should be a tiny fix, but should it be user_local or user_global?

@fperez
Member
fperez commented Dec 1, 2011

user_local, I think. Sorry I didn't fix it right away, I caught it during the lecture today and just moved on :)

@takluyver takluyver added a commit to takluyver/ipython that referenced this issue Dec 1, 2011
@takluyver takluyver Fix wildcard search for new namespace model.
Closes gh-1076
6376dd8
@takluyver
Member

Both, I think. See PR #1081.

@fperez
Member
fperez commented Dec 1, 2011

Closed by #1081.

@fperez fperez closed this Dec 1, 2011
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@takluyver takluyver Fix wildcard search for new namespace model.
Closes gh-1076
b277852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment