double pylab greeting with c.InteractiveShellApp.pylab = "tk" in zmqconsole #1170

Closed
juliantaylor opened this Issue Dec 17, 2011 · 7 comments

Projects

None yet

3 participants

@juliantaylor
Collaborator

I added c.InteractiveShellApp.pylab = "tk" to my config to get pylab with the zmqconsole.
you then get two pylab greetings when you start it:

ipython console
Welcome to pylab, a matplotlib-based Python environment [backend: TkAgg].
For more information, type 'help(pylab)'.
[IPKernelApp] To connect another client to this kernel, use:
[IPKernelApp] --existing kernel-3395.json

Welcome to pylab, a matplotlib-based Python environment [backend: TkAgg].
For more information, type 'help(pylab)'.

adding only c.TerminalIPythonApp.pylab = "tk" to the config will give you one greeting but pylab won't work which is a bit confusing.

@fperez
Member
fperez commented Dec 17, 2011

This will be solved by a refactoring: there should be a single kernel object anywhere and then a single frontend object a local client would be a frontend with an in-process kernel.

I hope to get to make that big cleanup in the spring.

@minrk
Member
minrk commented Dec 18, 2011

This is a minor oversight in the two-process frontend, which inherits from the Terminal application, but doesn't override init_gui_and_pylab() to be a no-op.

@fperez
Member
fperez commented Dec 18, 2011

Do you want to take a stab at fixing it? An eventual refactor will make this impossible by construction, but for now doing overrides in the subclasses is necessary and we alrady do it in multiple places, so we might as well ship 0.12 without this issue...

@minrk
Member
minrk commented Dec 18, 2011

Sure, it's two lines, PR incoming

@fperez
Member
fperez commented Dec 18, 2011

great!

@minrk
Member
minrk commented Dec 18, 2011

PR #1173

@fperez fperez closed this in c8874d7 Dec 18, 2011
@fperez
Member
fperez commented Dec 18, 2011

Awesome, reviewed and merged (keeping the merge handle as per our new approach :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment