Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsmagic returns JSON which makes for awkward UX in JupyterLab #11793

Open
fperez opened this issue Jun 19, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@fperez
Copy link
Member

commented Jun 19, 2019

I'm not sure why lsmagic needs to return a JSON data structure by default - but the end result is that in JupyterLab, it becomes kind of useless... In Classic calling %lsmagic produces (clipped for simplicity):

image

while in Lab, this is the output:

image

Lab defaults to showing JSON reprs when available, which typically makes sense, so while this is a change in behavior re. Classic, I'm inclined to think it's a good step forward.

Users can get the text via

image

but that's a pretty awkward experience. Do we really need lsmagic to produce JSON by default? It seems to me that generating plain text would be fine most of the time, perhaps with a --json/-j option for JSON output when desired?

@Carreau

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

That is used by the qtconsole to populate the qt menus dynamically I believe; so we would need to patch qtconsole to run with the --json option if we remove this default.

cc @ccordoba12

@ccordoba12

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

No problem in our side, the change should be quite simple to apply in qtconsole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.