Skip to content
This repository

should dv.sync_import print failed imports ? #1208

Closed
Carreau opened this Issue · 3 comments

2 participants

Matthias Bussonnier Min RK
Matthias Bussonnier
Collaborator

Hi,
I'm trying parallel magic, I just feel that sync_import should at least warn user if some import have failed/are not done, or at least state in the docstring that if import failed/are not done it stays silent.

Docstring don't mention local keyword, (should it ? even if no yet implemented ? )

Min RK
Owner

Yes and yes. The comments in the code clearly state:

            if not local:
                # ignore import errors if not doing local imports
                pass

But there needs to be an else: raise after that to actually raise the error.

Min RK minrk closed this issue from a commit
Min RK minrk DirectView.sync_imports fixes
ImportErrors are properly raised when no such package exists

describe `local` kwarg's purpose, indicating that `local=False`
is not implemented.

closes #1208
bf7d20d
Min RK
Owner

should be fixed

Matthias Bussonnier
Collaborator

Yes, it works.
just one other detail, maybe due to @contexmanager
When ? or ?? docstring state :
Definition: dv.sync_imports(*args, **kwds) which don't cite the definition of the non decorated function. Same with temp_flags but there is no parameters so not really important.

Brian E. Granger ellisonbg referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Nathan Rice nathan-rice referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Yaroslav Halchenko yarikoptic referenced this issue from a commit in yarikoptic/ipython
Min RK minrk DirectView.sync_imports fixes
ImportErrors are properly raised when no such package exists

describe `local` kwarg's purpose, indicating that `local=False`
is not implemented.

closes #1208
2d2cd9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.