Pathlib, Pathlib everywhere.

[Carreau]

There are many places where we could make use of Pathlib.

Look for any places that uses with open(...) and ask yourself:

• is the argument a string ?
• would it make sens to make it a Path(),
• how far upstream in the code can I make it a Path.

Don't try to bite more than you can chew (or more than I can review), try to fix 1 place at a time.

[Carreau]

for example see #12512

[Inception95]

Hi @Carreau, if no one is working on /core/page.py for using Pathlib, can I take this part?

[Carreau]

Hi @Carreau, if no one is working on /core/page.py for using Pathlib, can I take this part?

Sure, please. Thanks.

[barhenkro]

Hi, I would like to work on core/interactiveshell.py and add there more use of Pathlib.
Can I help with that?

[nicksspirit]

Hey @Carreau can I take on testing/iptestcontroller.py and core/magics/execution.py ?

[MrMino]

Might also be of use: https://docs.python.org/3/library/pathlib.html#correspondence-to-tools-in-the-os-module

There are many places other than with open() that might use pathlib treatment:

-    conda_history = os.path.join(sys.prefix, 'conda-meta', 'history')
-    return os.path.exists(conda_history)
+    return Path(sys.prefix, 'conda-meta', 'history').exists()

[nicksspirit]

That's a good point.

…

On Sat, Oct 10, 2020 at 8:33 PM Blazej Michalik ***@***.***> wrote: Might also be of use: https://docs.python.org/3/library/pathlib.html#correspondence-to-tools-in-the-os-module There are many places other than with open() that might use pathlib treatment: - conda_history = os.path.join(sys.prefix, 'conda-meta', 'history')- return os.path.exists(conda_history)+ return Path(sys.prefix, 'conda-meta', 'history').exists() — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12515 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADMY5F73MJDQ6CL32KEUZS3SKD4LXANCNFSM4QNPWX2Q> .

[MrMino]

Might also be of use: https://docs.python.org/3/library/pathlib.html#correspondence-to-tools-in-the-os-module

There are many places other than with open() that might use pathlib treatment:

Although... some of them might be less trivial and more error prone, especially when they're interpreted as text. For example, when returning a PosixPath object breaks code in the scope above because it is being ' '.join()-ed with other shell arguments.

[squarebat]

I am new to open source contribution and would love to work on this issue. After I am done with my changes, what would be the easiest way to test the code before I create a PR?

[davbrito]

I am new to open source contribution and would love to work on this issue. After I am done with my changes, what would be the easiest way to test the code before I create a PR?

Hello @squarebat
You should do this:

• Install the testing dependencies this by running this command in the root of the repo:

$ pip3 install -e .[test]

• Then execute the tests with

$ iptest

[squarebat]

I want to work on the test_run.py file. However, I'm having trouble resolving some errors in that file. The two main errors are

• undefined variable get_ipython (This one is resolved by adding an import but that seems wrong)

• undefined variable _ip : In some functions _ip is initialized as _ip = get_ipython() hence defining it, but in other functions it not initialized, hence causing error.

I have set up my environment using pip install .
I just wanted to know if I made a mistake while setting up the environment, or if there is a bug in the test_run.py file.

[davbrito]

I have set up my environment using pip install

You have to use pip install -e .[test]

The -e means that you Install it in editable mode.

[joesinghh]

Hello! This is my first time contributing to an open source project , I would like to work on this issue .
can i get assigned ?

[nitin-pandita]

Hey, I would love to work on this issue, as a beginner in Open source I think I can make it work. Thank you