Skip to content
This repository

in Hub: registration_timeout must be an integer, but heartmonitor.period is CFloat #1281

Closed
rameshvs opened this Issue · 3 comments

3 participants

Ramesh Sridharan Fernando Perez Min RK
Ramesh Sridharan

In parallel.controller.hub, the registration_timeout is set to max(5000, 2*self.heartmonitor.period) and must be an integer, but self.heartmonitor.period is a float.

So, when the period is more than 2500 (doesn't happen with the default value of 1000; only with user-modified values that are higher), a validation error occurs and the hub doesn't start.

Fernando Perez
Owner

@minrk, a simple int(...) around that should do the trick, no?

Min RK
Owner

Indeed, that would fix it, though there's no reason the two shouldn't be the same type. Since these are millisecond times, I will make them both Integer (sub millisecond precision makes no sense).

Min RK
Owner

PR #1283 issues making HeartMonitor.period an integer.

Min RK minrk closed this in 8e9cbc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.