Input parsing with %prun clobbers escapes #1302

Closed
wesm opened this Issue Jan 20, 2012 · 4 comments

Comments

Projects
None yet
3 participants

wesm commented Jan 20, 2012

Running this command, where foo.csv is a tab-separated file

In [3]: %prun -s cumulative table = read_table('foo.csv', sep="\t")

it blows up and I stepped up to the top level to see that sep has been passed as t and not \t

Owner

ivanov commented Jan 20, 2012

on it, another parse_options issue - removing the line parameter_s = parameter_s.replace('"',r'\"').replace("'",r"\'") in prun and adding posix=False to parse_options seems to solve it, writing test and looking for other places to apply the fix now

ivanov added a commit to ivanov/ipython that referenced this issue Jan 21, 2012

ivanov added a commit to ivanov/ipython that referenced this issue Jan 21, 2012

Owner

fperez commented Jan 21, 2012

@wesm, I'm merging @ivanov's fix now, let us know if you notice any other issues.

@fperez fperez closed this in 6bc0f53 Jan 21, 2012

wesm commented Jan 22, 2012

That's wonderful, thank you guys for being so responsive

Owner

fperez commented Jan 22, 2012

Satisfaction guaranteed or your money back :)

minrk added a commit to minrk/ipython that referenced this issue Jan 28, 2012

minrk added a commit to minrk/ipython that referenced this issue Jan 28, 2012

ivanov added a commit that referenced this issue Apr 6, 2012

yarikoptic pushed a commit to yarikoptic/ipython that referenced this issue May 2, 2014

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

Merge pull request #1306 from ivanov/fix1302
Fix %prun input parsing for escaped characters (closes #1302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment