Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Notebook printing broken #1339

Closed
fperez opened this Issue · 6 comments

3 participants

@fperez
Owner

The print view in the notebook is currently completely broken. As Mark Voorhies pointed out on the list, during the Wijmo menu reorganization it was lost. We should try to restore it asap, b/c I know many people do use printing to generate static pdfs.

@ellisonbg
Owner

Can you clarify what is broken about it. It was broken, but I spent a good while completely redoing it. I just tested it on a simple page and it worked fine.

@fperez
Owner

I just double-checked by refreshing, and I'm still seeing the problem; confirmed both in FF and chrome. The print view only shows me one empty cell, no matter what the notebook has. The type of the cell shown is correct (markdown or code) but I only see one cell, and it has no content.

This is on current master, confirmed both with existing notebooks and a newly created one.

@markvoorhies

For commit 93bb469 on Ubuntu 10.04 w/ Firefox 9.01/NoScript (with scripts allowed for localhost and mathjax):
Start kernel with: ipython notebook
Click "new notebook" on dashboard
In new notebook: print "Hello world"
Choose "print view" from notebook menu
--> print view opens in new tab as notebook with one empty cell and no menu bar.

@ellisonbg
Owner

Fixed in #1361

@markvoorhies

Tested commit 648d2de from #1361 with Firefox 9 on a notebook that prints correctly from the last stable print view version (commit a50ac36). Print view works again =), and "save as web page complete" and "print to pdf" from Firefox both work.

Minor issues :

  • Less-than and greater-than symbols are being double escaped (e.g., to &lt; instead of <) (c.f. markdown source for what I mean)
  • Code cells still have cursors and can be edited/run (I think this is intentional)

So, printing is totally usable as of this commit. Thanks!

@fperez
Owner

Confirming it appears fixed by #1361, thanks! The print view does remain editable which at some point I think it wasn't, but you've mentioned there was some refactoring needed re. the read-only use, so we can revisit that point later if it works best that way.

I think having the print view be read-only is a valid enhancement request, but not really a bug, so as far as I'm concerned this is fixed.

@fperez fperez closed this in 54c3e06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.