Channels should be named for their function, not their socket type #178

Closed
minrk opened this Issue Oct 21, 2010 · 0 comments

1 participant

@minrk
IPython member

Currently, Kernel/KernelManager have channel classes whose names are based on their socket types, such as XreqChannel, PubChannel, etc.

If future functionality is added via another socket of the same type, or the same behavior is provided by a different socket type, this naming no longer makes sense

These names should be changed to represent functionality, rather than socket type to prevent future collisions.

As an example, the parallel code has 3 channels that, as far as the kernel is concerned, are exactly the same as the current XreqChannel. Their socket types can be XREQ, PAIR, or XREP.

@minrk minrk added a commit to minrk/ipython that referenced this issue Jun 1, 2011
@minrk minrk cleanup channel names to match function not socket
closes gh-178
426248c
@minrk minrk added a commit to minrk/ipython that referenced this issue Jun 7, 2011
@minrk minrk cleanup channel names to match function not socket
closes gh-178
4b4abf9
@minrk minrk closed this in 7940e2f Jun 10, 2011
@jenshnielsen jenshnielsen pushed a commit to jenshnielsen/ipython that referenced this issue Jun 21, 2011
@minrk minrk cleanup channel names to match function not socket
closes gh-178
5e622ef
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk minrk cleanup channel names to match function not socket
closes gh-178
625fd57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment