Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Channels should be named for their function, not their socket type #178

Closed
minrk opened this Issue · 0 comments

1 participant

@minrk
Owner

Currently, Kernel/KernelManager have channel classes whose names are based on their socket types, such as XreqChannel, PubChannel, etc.

If future functionality is added via another socket of the same type, or the same behavior is provided by a different socket type, this naming no longer makes sense

These names should be changed to represent functionality, rather than socket type to prevent future collisions.

As an example, the parallel code has 3 channels that, as far as the kernel is concerned, are exactly the same as the current XreqChannel. Their socket types can be XREQ, PAIR, or XREP.

@minrk minrk referenced this issue from a commit in minrk/ipython
@minrk minrk cleanup channel names to match function not socket
closes gh-178
426248c
@minrk minrk referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@minrk minrk referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@minrk minrk referenced this issue from a commit in minrk/ipython
@minrk minrk cleanup channel names to match function not socket
closes gh-178
4b4abf9
@minrk minrk closed this in 7940e2f
@jenshnielsen jenshnielsen referenced this issue from a commit in jenshnielsen/ipython
@minrk minrk cleanup channel names to match function not socket
closes gh-178
5e622ef
@ellisonbg ellisonbg referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@damianavila damianavila referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@mattvonrocketstein mattvonrocketstein referenced this issue from a commit in mattvonrocketstein/ipython
@minrk minrk cleanup channel names to match function not socket
closes gh-178
625fd57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.