setup fails for python3 with LANG=C #2057

Closed
juliantaylor opened this Issue Jun 30, 2012 · 19 comments

Projects

None yet

3 participants

@juliantaylor
Collaborator

since Jörgen was added do release.py python3 fails due to the umlaut on systems with LANG=C

$ LANG=C python3.2 setup.py build
Traceback (most recent call last):
  File "setup.py", line 61, in <module>
    from setupbase import target_update
  File "/tmp/ipython-ipython-da134db/setupbase.py", line 74, in <module>
    execfile(pjoin('IPython','core','release.py'), globals())
  File "/tmp/ipython-ipython-da134db/setupbase.py", line 55, in execfile
    exec(compile(open(fname).read(), fname, "exec"), globs, locs)
  File "/usr/lib/python3.2/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 4379: ordinal not in range(128)
@fperez
Member
fperez commented Jun 30, 2012

Does a python2 build succeed?

@juliantaylor
Collaborator

its an py3 only code path in setupbase.py:55
py2 works fine

@fperez
Member
fperez commented Jun 30, 2012

ouch... this is a bad one, b/c LANG=C is pretty common...

@fperez
Member
fperez commented Jun 30, 2012

pypi shows zero downloads on all, so I'm tempted to just retag 0.13 fixing only ö -> o in that file and nothing else. thoughts?

@juliantaylor
Collaborator

please don't I already uploaded the tag to debian

@fperez
Member
fperez commented Jun 30, 2012

ok

@fperez
Member
fperez commented Jun 30, 2012

how serious is this one for debian?

@juliantaylor
Collaborator

not bad I just set the build to LC_ALL=C.UTF-8
is LANG=C really so common?

@fperez
Member
fperez commented Jun 30, 2012

honestly I don know in the wild. Maybe not as much anymore... Windows certainly doesn set LANG by default. let me check an osx box...

@fperez
Member
fperez commented Jun 30, 2012

would debian accept a 0.13.1 in a month or so with any small fixes we accumulate?

@juliantaylor
Collaborator

as only python3 is affected and not everyone uses LANG=C I would suggest waiting a bit and bundling it in an early bugfix release
its likely a couple of bugs will get discovered soon now that a stable release is out

@fperez
Member
fperez commented Jun 30, 2012

same thing :)

@fperez
Member
fperez commented Jun 30, 2012

the buildbots are all solid and we did run all tests manually on mac, windows and linux at the very end, so I'm not too worried. we just didn't have this particular configuration

@fperez
Member
fperez commented Jun 30, 2012

yup, osx also sets LANG by default to a UTF-8 locale.

so let's leave this one be, it looks like it will mostly only be a problem for odd combinations of very old unix setups and people wanting to run on python3. That's an unusual setup, so it probably won't matter much.

I'll tag it for a backport to 0.13.1, does that sound OK?

@juliantaylor
Collaborator

sounds good.
As long as the fixes in a potential 0.13.1 aren't to invasive it can still be added to Debian.
Fixing this in it would be fine.

@fperez
Member
fperez commented Jun 30, 2012

OK, I've made a backport 0.13.1 label. We can start using that to tag potential backport issues for a 0.13.1 branch, which we'll make soon. You can give us feedback on what's a good idea and what's too much for Debian.

I'd like to try to keep 0.13.1 debian-compatible, and we can always cut a more aggressive 0.13.2 with more invasive fixes afterwards that could be OK for ubuntu/EPD/etc.

Does that sound like a good policy for you guys?

@minrk
Member
minrk commented Jun 30, 2012

The bugs in #1589 are due to an ASCII locale, but they are quite rare. I'm fine with leaving it for 0.13.1, but if we get a few reports of failures, then we can cut an early patch release.

@minrk
Member
minrk commented Jun 30, 2012

Ah, I had missed that this is py3-specific. Much less pressure, then.

@fperez
Member
fperez commented Jun 30, 2012

OK, let's ride it out and see how it goes. Also note that it's py3-only, further decreasing the impact surface (which is the intersection of old-school Unix configuration with Python 3)

@fperez fperez closed this in ba2907d Jul 1, 2012
@Carreau Carreau added a commit to Carreau/ipython that referenced this issue Jul 13, 2012
@fperez fperez Remove umlauts so py3 installations on LANG=C systems succeed.
Closes #2057.

backported to 0.13.1 from ba2907d
a5f1a0c
@minrk minrk added a commit that referenced this issue Jul 21, 2012
@minrk minrk Backport PR #2063: Remove umlauts so py3 installations on LANG=C syst…
…ems succeed.

Closes #2057.
4218f42
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@fperez fperez Remove umlauts so py3 installations on LANG=C systems succeed.
Closes #2057.
a0e158f
@detrout detrout pushed a commit to detrout/debian-ipython that referenced this issue Oct 13, 2015
jtaylor-guest build with LC_ALL=C.UTF-8 to avoid a unicode issue in setupbase.py
ipython/ipython#2057

git-svn-id: svn://anonscm.debian.org/python-modules/packages/ipython/trunk@22384 771dd761-d7fa-0310-a302-f036d1c1ebb6
1cbcd13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment