SSH passwordless check with OpenSSH checks for the wrong thing #2266

Closed
ikn opened this Issue Aug 7, 2012 · 3 comments

Comments

Projects
None yet
4 participants
Contributor

ikn commented Aug 7, 2012

The pattern passed to pexpect is '[Ppassword]:', which looks for any of those letters followed by ':', and not, as the intention seems to be, for 'Password:'. The correct pattern is '[Pp]assword:'.

This is at IPython/external/ssh/tunnel.py:100.

Contributor

bfroehle commented Aug 8, 2012

I agree. Do you want to open a pull request?

Contributor

ikn commented Aug 10, 2012

Hmm, well, I thought it was trivial enough not to bother, but if that's how things are done here, I guess I should. Not sure if there's a smart way to link to pull requests, but it's here: #2280 .

Owner

fperez commented Aug 10, 2012

@ikn, you can just metion any issue/PR by its number and github auto-converts that to a link: #2280, when typed without escapes, will link (on the github website, not on the emails) to your PR: #2880.

@minrk minrk closed this in f9a87d2 Aug 11, 2012

minrk added a commit that referenced this issue Aug 11, 2012

Merge pull request #2280 from ikn/master
fix SSH passwordless check for OpenSSH

typo in pexpect pattern

closes #2266

Carreau added a commit to Carreau/ipython that referenced this issue Sep 5, 2012

fix check for passwordless OpenSSH (fixes #2266)
pexpect takes a regular expression, so we want '[Pp]assword:', not
'[Ppassword]:'.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

fix check for passwordless OpenSSH (fixes #2266)
pexpect takes a regular expression, so we want '[Pp]assword:', not
'[Ppassword]:'.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

Merge pull request #2280 from ikn/master
fix SSH passwordless check for OpenSSH

typo in pexpect pattern

closes #2266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment