Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update cython_extension.ipynb to include `--annotate` examples #2286

Closed
bfroehle opened this Issue Aug 10, 2012 · 3 comments

Comments

Projects
None yet
4 participants
Contributor

bfroehle commented Aug 10, 2012

In #2225 we added the --annotate option to %%cython but failed to update the example notebook to show this feature. We should update the notebook to show off this feature, or perhaps add a new notebook which maybe walks through a basic example provided with cython (e.g., http://docs.cython.org/src/quickstart/cythonize.html#determining-where-to-add-types).

Owner

fperez commented Aug 10, 2012

Thanks for filing it, Brad!

Owner

fperez commented Aug 13, 2012

It would be nice if as part of this, we could figure out (and correct) the source of the extra vertical whitespace that I'm seeing (and @ellisonbg confirmed) in the annotated HTML:

image

I don't know why that's happening, but it seems like we're adding blank lines unnecessarily. Maybe it's just that something is doing '\n'.join(somelist) when it should instead read ''.join(somelist), not sure...

Contributor

bfroehle commented Aug 14, 2012

Yes, I see it too. It's coming from the CSS that the notebook uses. The notebook viewer displays the annotated source without extra spacing.

If you want to play around with the CSS without installing Cython, I've posted a simple notebook which you can download and work with.

@minrk minrk modified the milestones: no action, wishlist Oct 5, 2014

@ellisonbg ellisonbg closed this Jan 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment