Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

remote tracebacks broken since 952d0d6 (PR #2223) #2303

Closed
juliantaylor opened this Issue Aug 14, 2012 · 3 comments

Comments

Projects
None yet
3 participants

since 952d0d6 PR #2223 broke remote tracebacks:

from IPython.parallel import Client
c = Client()
dv = c[:]
dv.execute("from nump import *").get()

outputs "No traceback available" instead of the tracebacks
this affects HEAD and the 0.13.1 branch

I also think this backport is not really appropriate for a bugfix branch

the issue was discovered by syamajala on irc who was following 0.13.1

Owner

takluyver commented Aug 14, 2012

We wouldn't normally backport something like that, but we felt the issue it
fixed was sufficiently serious to be worth applying to the 0.13 branch.
Thanks for reporting it before we do a 0.13.1.

Owner

minrk commented Aug 14, 2012

It was a tough call backporting, since it was an important fix, but the fix itself changed more than we normally would for a backport. Fixing this issue is trivial, see #2305.

@minrk minrk closed this in 09b440a Aug 26, 2012

@minrk minrk added a commit that referenced this issue Aug 26, 2012

@minrk minrk Merge pull request #2305 from minrk/render_traceback
RemoteError._render_traceback_ calls self.render_traceback

rather than an alias, which can be broken by subclassing

closes #2303
58335ad

@minrk minrk added a commit that referenced this issue Aug 26, 2012

@minrk minrk Backport PR #2305: RemoteError._render_traceback_ calls self.render_t…
…raceback

rather than an alias

There are two options here:

1. `_render_traceback_`  should *call* render_traceback
2. any subclass that redefines render_traceback must also redefine `_render_traceback_`

I went with 1., which is more efficient code-wise when subclassing RemoteError
(would prevent future cases of this same mistake),
but less efficient execution-wise, because it involves an extra function call.

closes #2303
7069803

@minrk minrk added a commit that referenced this issue Sep 1, 2012

@minrk minrk Backport PR #2305: RemoteError._render_traceback_ calls self.render_t…
…raceback

rather than an alias

There are two options here:

1. `_render_traceback_`  should *call* render_traceback
2. any subclass that redefines render_traceback must also redefine `_render_traceback_`

I went with 1., which is more efficient code-wise when subclassing RemoteError
(would prevent future cases of this same mistake),
but less efficient execution-wise, because it involves an extra function call.

closes #2303
0e42613

@Carreau Carreau added a commit to Carreau/ipython that referenced this issue Sep 5, 2012

@minrk @Carreau minrk + Carreau RemoteError._render_traceback_ calls self.render_traceback
rather than an alias

There are two options here:

1. `_render_traceback_`  should *call* render_traceback
2. any subclass that redefines render_traceback must also redefine `_render_traceback_`

I went with 1., which is more efficient code-wise when subclassing RemoteError
(would prevent future cases of this same mistake),
but less efficient execution-wise, because it involves an extra function call.

closes #2303
cb959b0

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

@minrk minrk RemoteError._render_traceback_ calls self.render_traceback
rather than an alias

There are two options here:

1. `_render_traceback_`  should *call* render_traceback
2. any subclass that redefines render_traceback must also redefine `_render_traceback_`

I went with 1., which is more efficient code-wise when subclassing RemoteError
(would prevent future cases of this same mistake),
but less efficient execution-wise, because it involves an extra function call.

closes #2303
d042f1e

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

@minrk minrk Merge pull request #2305 from minrk/render_traceback
RemoteError._render_traceback_ calls self.render_traceback

rather than an alias, which can be broken by subclassing

closes #2303
1d01a1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment