client doesn't use connection file's 'location' in disambiguating 'interface' #2361

Closed
ikn opened this Issue Aug 30, 2012 · 3 comments

Projects

None yet

2 participants

@ikn
Contributor
ikn commented Aug 30, 2012

be9601b seems to have changed client.py to stop using location in the call to util.disambiguate_ip_address (previously util.disambiguate_url). This means that if interface's address is '*', the client tries to connect to localhost, which doesn't seem to me to be the correct behaviour.

The fix appears to be as simple as

-        addr = util.disambiguate_ip_address(addr)
+        addr = util.disambiguate_ip_address(addr, location)
Owner
minrk commented Aug 30, 2012

Indeed - I caught the same typo in ipengineapp, but missed this one. Want to make a Pull Request?

Contributor
ikn commented Aug 30, 2012

I feel like I should reference it from here or something - #2364.

@minrk minrk pushed a commit that closed this issue Aug 30, 2012
@ikn ikn make clients use 'location' properly (fixes #2361)
This fixes a previous change that removed the location argument from the
call to util.disambiguate_ip_address, which stops it getting used where
interface is * or 0.0.0.0.
bf94297
@minrk minrk closed this in bf94297 Aug 30, 2012
Owner
minrk commented Aug 31, 2012

fix merged, thanks!

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@ikn ikn make clients use 'location' properly (fixes #2361)
This fixes a previous change that removed the location argument from the
call to util.disambiguate_ip_address, which stops it getting used where
interface is * or 0.0.0.0.
236dc6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment