Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

find_job_cmd is too hasty to fail on Windows #26

Closed
ipython opened this Issue May 10, 2010 · 3 comments

Comments

Projects
None yet
4 participants
@ghost

ghost commented May 10, 2010

Original Launchpad bug 503903: https://bugs.launchpad.net/ipython/+bug/503903
Reported by: ellisonbg (Brian Granger).

The find_job_cmd function at line 565 of launcher.py fails on line 560 when the Windows HPC stuff is not installed.
But find_job_cmd is called at import (always), so it fails.

We should probably just return 'job' if find_cmd('job') fails.

This is only used on Windows.

def find_job_cmd():
if os.name=='nt':
return find_cmd('job')
else:
return 'job'

Owner

takluyver commented Mar 23, 2011

Is this still an issue in trunk?

Owner

ellisonbg commented Mar 31, 2011

Yes, we should keep this around until we fix the Windows HPC support in newparallel.

@ellisonbg ellisonbg was assigned Apr 10, 2011

Owner

minrk commented Apr 18, 2011

Since we do have a specific WinHPC support Issue (#340), I'm closing this, since the mentioned bug is indeed fixed.

@minrk minrk closed this Apr 18, 2011

@minrk minrk pushed a commit to minrk/ipython that referenced this issue Jul 1, 2013

@Carreau Carreau Merge pull request #26 from Carreau/utf8fix
fix utf8 for html output.

This hardcode utf-8 in html templates
ef67f84

@jdfreder jdfreder added a commit that referenced this issue Feb 26, 2015

@jdfreder jdfreder Merge pull request #26 from takluyver/widget-migration-fix-formatting
Fix formatting in list of widget PRs and issues
3bb081f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment