Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Small change needed to rmagic extension. #2615

Closed
milkypostman opened this Issue · 2 comments

3 participants

Donald Ephraim Curtis Thomas Kluyver Min RK
Donald Ephraim Curtis

https://github.com/ipython/ipython/blob/master/IPython/extensions/rmagic.py#L326

When parsing arguments for %R the rmagic extension requires the units argument (-u / --units) to be an integer, but the parameter is supposed to be one of ["px", "in", "cm", "mm"] and thus it is impossible to pass this argument.

Thomas Kluyver
Owner

I think you're right. Do you want to submit a pull request? Just click 'edit this file' on rmagic.py. It will also need a little tweak around line 510, because we'll need to pass that argument with quotation marks around it.

Thomas Kluyver
Owner

Closed by PR #2617.

Thomas Kluyver takluyver closed this
Min RK minrk added this to the 1.0 milestone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.