Small change needed to rmagic extension. #2615

Closed
milkypostman opened this Issue Nov 24, 2012 · 2 comments

Comments

Projects
None yet
3 participants
Contributor

milkypostman commented Nov 24, 2012

https://github.com/ipython/ipython/blob/master/IPython/extensions/rmagic.py#L326

When parsing arguments for %R the rmagic extension requires the units argument (-u / --units) to be an integer, but the parameter is supposed to be one of ["px", "in", "cm", "mm"] and thus it is impossible to pass this argument.

Owner

takluyver commented Nov 24, 2012

I think you're right. Do you want to submit a pull request? Just click 'edit this file' on rmagic.py. It will also need a little tweak around line 510, because we'll need to pass that argument with quotation marks around it.

Owner

takluyver commented Jan 8, 2013

Closed by PR #2617.

@takluyver takluyver closed this Jan 8, 2013

@minrk minrk added this to the 1.0 milestone Mar 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment