Test failure with FileLinks class on Windows #2732

Closed
takluyver opened this Issue Jan 2, 2013 · 8 comments

Comments

Projects
None yet
2 participants
Owner

takluyver commented Jan 2, 2013

======================================================================
FAIL: FileLinks: Calling _repr_html_ functions as expected on existing dir
----------------------------------------------------------------------
Traceback (most recent call last):
  File "S:\Users\slave\Jenkins\shiningpanda\d5f643a2\virtualenvs\ff035a1d\lib\site-packages\nose\case.py", line 197, in runTest
    self.test(*self.arg)
  File "S:\Users\slave\Jenkins\shiningpanda\d5f643a2\virtualenvs\ff035a1d\lib\site-packages\ipython-0.14.dev-py2.7.egg\IPython\lib\tests\test_display.py", line 97, in test_existing_path_FileLinks
    nt.assert_equal(actual,expected)
AssertionError: Lists differ: ["&nbsp;&nbsp;<a href='files/c... != ["&nbsp;&nbsp;<a href='files/c...

First differing element 0:
&nbsp;&nbsp;<a href='files/c:\users\slave\appdata\local\temp\tmprdhtvl/tmp18db_h' target='_blank'>tmp18db_h</a><br>
&nbsp;&nbsp;<a href='files/c:\users\slave\appdata\local\temp\tmprdhtvl\tmp18db_h' target='_blank'>tmp18db_h</a><br>

Note that the last slash in the href changes - actual has a forward slash, expected a backslash.

Ping @gregcaporaso, who added those classes.

Example ShiningPanda failure at https://jenkins.shiningpanda.com/ipython/job/ipython-win-py27/lastBuild/console

Contributor

gregcaporaso commented Jan 2, 2013

OK, thanks for catching this. I'll work on the fix, but don't have a windows box to test on. How is windows testing typically handled for devs who don't have access to a windows machine?

Owner

takluyver commented Jan 2, 2013

I don't think we've got a good answer to that question, unfortunately. For simple problems, we tend to commit something that we think should fix it, and then either get someone with Windows to test it, or merge it and wait for a ShiningPanda build. For more complex problems, a dev who does have Windows might step forwards. I think @jstenar is the main Windows user, although several of the other devs have Windows VMs they can test in.

Contributor

gregcaporaso commented Jan 2, 2013

OK, thanks. I'll work on a fix for this ASAP (in the next day or two).

Owner

takluyver commented Jan 11, 2013

@gregcaporaso - just checking for updates on this one - have you had a chance to have a look at it? I might add you to ShiningPanda's email notifications of build failures ;-)

Contributor

gregcaporaso commented Jan 11, 2013

Sorry, I haven't but will this weekend.

gregcaporaso added a commit to gregcaporaso/ipython that referenced this issue Jan 11, 2013

fix for issue #2732
all occurrences of '/' were replaced with os.sep. This should address issues with broken links on Windows, but I don't have access to a Windows machine to test this. Can someone with a Windows machine please test before merging?

gregcaporaso added a commit to gregcaporaso/ipython that referenced this issue Jan 15, 2013

this should address the failure in #2732
i am still very concerned that I can't test this on windows - I'm not used to developing for windows, so not sure that these links will work even if the test passes on windows.

is there a good AWS AMI to use for windows testing? i can run this in my own AWS account.

takluyver added a commit that referenced this issue Jan 27, 2013

Owner

takluyver commented Jan 27, 2013

Memo to self: this should be fixed now. If the next Shiningpanda Windows build succeeds, I'll close it.

Owner

takluyver commented Jan 29, 2013

It's passing again. Thanks @gregcaporaso.

@takluyver takluyver closed this Jan 29, 2013

Contributor

gregcaporaso commented Jan 29, 2013

Excellent!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

this should address the failure in #2732
i am still very concerned that I can't test this on windows - I'm not used to developing for windows, so not sure that these links will work even if the test passes on windows.

is there a good AWS AMI to use for windows testing? i can run this in my own AWS account.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

Merge pull request #2844 from gregcaporaso/issue-2732
this should address the failure in #2732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment