Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Move Delete Button Away from Save Button in the HTML notebook toolbar #2923

Closed
zachcp opened this Issue Feb 12, 2013 · 4 comments

Comments

Projects
None yet
4 participants

zachcp commented Feb 12, 2013

I have a suggestion for a small improvement to the HTML notebook: move the Delete and Save buttons away from one another. I have accidentally deleted cells on a number of occasions when my intention was to press save. Although #2920 and #2921 will allow ways to restore deleted cells, I think moving the delete button over (maybe shuffling it to the other side of the Copy/Paste buttons?) would help prevent accidental cell deletions.

Owner

minrk commented Feb 12, 2013

That button is 'cut', not 'delete', so the cell is in your clipboard, not gone. I don't think the ordering of cut/copy/paste should deviate from the extremely standard ordering, but I suppose we could move the trio. Maybe move run/interrupt pair in-between save and C/C/P.

And #2921 doesn't add any functionality, it only adds it to the menu - it is already available in the kb shortcuts.

zachcp commented Feb 12, 2013

Thanks for the tips.

iPython is awesome and this was a very minor complaint.

Owner

Carreau commented Feb 13, 2013

Ctrl-m,s (and Ctrl-s in some browser) should trigger saving also. Reaching the mouse is hard sometime...

Contributor

ArcTanSusan commented Nov 25, 2013

PR is here: #2921 Feel free to code review.

@ArcTanSusan ArcTanSusan added a commit to ArcTanSusan/ipython that referenced this issue Nov 28, 2013

@ArcTanSusan ArcTanSusan Fixed #2923 Move Save Away from Cut in toolbar dce25f6

@minrk minrk closed this in #4594 Dec 4, 2013

@minrk minrk added a commit that referenced this issue Dec 4, 2013

@minrk minrk Merge pull request #4594 from onceuponatimeforever/2923
Fixed #2923 Move Save Away from Cut in toolbar

replace add above/below arrows with single plus button
733e82e

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

@ArcTanSusan ArcTanSusan Fixed #2923 Move Save Away from Cut in toolbar 76554b7

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

@minrk minrk Merge pull request #4594 from onceuponatimeforever/2923
Fixed #2923 Move Save Away from Cut in toolbar

replace add above/below arrows with single plus button
fc72b98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment