Skip to content
This repository

Make sure that the Windows installer handles the top-level IPython scripts. #351

Closed
ellisonbg opened this Issue April 09, 2011 · 6 comments

3 participants

Brian E. Granger Min RK Darren Dale
Brian E. Granger
Owner

We have some hacky, fragile code that installs the top-level scripts for the MSI installer. This code need to be tested, checked, etc. before the release.

Darren Dale
ddale commented April 10, 2011

Are you referring to ipython_win_post_install.py? Just a comment, I don't think bdist_msi is compatible with post-install scripts. I'd love to be proven wrong, but I've never been able to get it to work, and have had to use bdist_wininst instead.

Brian E. Granger
Owner
Darren Dale
ddale commented April 11, 2011
Brian E. Granger
Owner
Darren Dale
ddale commented April 11, 2011

No, but I think it should be easy enough to add .bat or .exe files to the list of scripts when setup.py is run on windows. Then they would be included in the msi installer.

I think there is some value to having an IPython launcher in the start menu. It makes IPython more accessible to new users on windows: they don't have to modify environment variables to add C:\Python27 and C:\Python27\Scripts to the path.

Min RK
Owner
minrk commented June 22, 2011

I just ran python setup.py bdist_wininst on my Win7 VM with current master, and after removing all traces of IPython and running the installer, every script seems to work just fine (I do have C:\Python27 and C:\Python27\Scripts in my PATH).

I did update the post_install script in #536 to match recent changes, and it appears to work, including Start menu items, as long as setuptools is installed.

Min RK minrk closed this issue from a commit June 24, 2011
Min RK Merge branch 'winsetup' (PR #536)
introduces install dependency of setuptools on Windows

This is a temporary fix, and the setuptools dependency should
be removed in 0.12.

closes gh-536
closes gh-351
closes gh-369
933e2d9
Min RK minrk closed this in 933e2d9 June 24, 2011
Brian E. Granger ellisonbg referenced this issue from a commit January 10, 2012
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.