Make sure that the Windows installer handles the top-level IPython scripts. #351

Closed
ellisonbg opened this Issue Apr 10, 2011 · 6 comments

Projects

None yet

3 participants

@ellisonbg
Member

We have some hacky, fragile code that installs the top-level scripts for the MSI installer. This code need to be tested, checked, etc. before the release.

@ellisonbg ellisonbg was assigned Apr 10, 2011
@ddale
ddale commented Apr 10, 2011

Are you referring to ipython_win_post_install.py? Just a comment, I don't think bdist_msi is compatible with post-install scripts. I'd love to be proven wrong, but I've never been able to get it to work, and have had to use bdist_wininst instead.

@ellisonbg
Member

Darren,

Yes, I meant bdist_wininst. But, that brings up a question: should
be be using bdist_msi instead? Would it "just work" in terms of
installing top-level scripts without any additional (and fragile)
magic on our parts?

Brian

On Sun, Apr 10, 2011 at 5:34 AM, ddale
reply@reply.github.com
wrote:

Are you referring to ipython_win_post_install.py? Just a comment, I don't think bdist_msi is compatible with post-install scripts. I'd love to be proven wrong, but I've never been able to get it to work, and have had to use bdist_wininst instead.

Reply to this email directly or view it on GitHub:
#351 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@ddale
ddale commented Apr 11, 2011

Unfortunately, not if you want to install anything into the windows start
menu.
On Apr 11, 2011 12:27 AM, "ellisonbg" <
reply@reply.github.com>
wrote:

Darren,

Yes, I meant bdist_wininst. But, that brings up a question: should
be be using bdist_msi instead? Would it "just work" in terms of
installing top-level scripts without any additional (and fragile)
magic on our parts?

Brian

On Sun, Apr 10, 2011 at 5:34 AM, ddale
reply@reply.github.com
wrote:

Are you referring to ipython_win_post_install.py? Just a comment, I don't
think bdist_msi is compatible with post-install scripts. I'd love to be
proven wrong, but I've never been able to get it to work, and have had to
use bdist_wininst instead.

Reply to this email directly or view it on GitHub:
#351 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

Reply to this email directly or view it on GitHub:
#351 (comment)

@ellisonbg
Member

Darren,

Unfortunately, not if you want to install anything into the windows start
menu.

I don't think we care one bit about the start menu. The only thing we
need to work is that .bat or .exe versions of the top-level ipython
scripts get created. Do you have any experience with using bdist_msi
for that?

Brian

On Apr 11, 2011 12:27 AM, "ellisonbg" <
reply@reply.github.com>
wrote:

Darren,

Yes, I meant bdist_wininst. But, that brings up a question: should
be be using bdist_msi instead? Would it "just work" in terms of
installing top-level scripts without any additional (and fragile)
magic on our parts?

Brian

On Sun, Apr 10, 2011 at 5:34 AM, ddale
reply@reply.github.com
wrote:

Are you referring to ipython_win_post_install.py? Just a comment, I don't
think bdist_msi is compatible with post-install scripts. I'd love to be
proven wrong, but I've never been able to get it to work, and have had to
use bdist_wininst instead.

Reply to this email directly or view it on GitHub:
#351 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

Reply to this email directly or view it on GitHub:
#351 (comment)

Reply to this email directly or view it on GitHub:
#351 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@ddale
ddale commented Apr 11, 2011

No, but I think it should be easy enough to add .bat or .exe files to the list of scripts when setup.py is run on windows. Then they would be included in the msi installer.

I think there is some value to having an IPython launcher in the start menu. It makes IPython more accessible to new users on windows: they don't have to modify environment variables to add C:\Python27 and C:\Python27\Scripts to the path.

@minrk
Member
minrk commented Jun 23, 2011

I just ran python setup.py bdist_wininst on my Win7 VM with current master, and after removing all traces of IPython and running the installer, every script seems to work just fine (I do have C:\Python27 and C:\Python27\Scripts in my PATH).

I did update the post_install script in #536 to match recent changes, and it appears to work, including Start menu items, as long as setuptools is installed.

@minrk minrk added a commit that closed this issue Jun 24, 2011
@minrk minrk Merge branch 'winsetup' (PR #536)
introduces install dependency of setuptools on Windows

This is a temporary fix, and the setuptools dependency should
be removed in 0.12.

closes gh-536
closes gh-351
closes gh-369
933e2d9
@minrk minrk closed this in 933e2d9 Jun 24, 2011
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk minrk Merge branch 'winsetup' (PR #536)
introduces install dependency of setuptools on Windows

This is a temporary fix, and the setuptools dependency should
be removed in 0.12.

closes gh-536
closes gh-351
closes gh-369
5d5d81f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment