windows source install doesn't create scripts correctly #369

Closed
fperez opened this Issue Apr 12, 2011 · 5 comments

Projects

None yet

3 participants

@fperez
IPython member

Reported on-list, see
http://mail.scipy.org/pipermail/ipython-dev/2011-April/007477

Installing IPython from source went fine, again using python setup.py install.
At this stage I was at a bit of a loss as to how to test it, my normal ipython
shortcut seemed to still load up my old version 10.1. I found a file
"ipython-qtconsole" in my Python26/Scripts directory but without a suffix or
associated .bat file it wasn't directly executable. This was easily resolved by
creating a bat file iqlab.bat with the contents:

@"C:\dev\bin\Python26\python.exe"
"C:\dev\bin\Python26\scripts\ipython-qtconsole"
--paging vsplit --pylab inline %*
@fperez
IPython member

For the script creation, we can probably add a simple check to see if 'install' is passed on win32, and import setuptools. I think that will ensure the scripts are created. Still, we need to check this, I could be wrong on this one.

@ddale

Are you sure you want to make setuptools a dependency on windows? I recently removed setuptools dependencies in my own projects. On windows, I did the following in setup.py (see https://github.com/praxes/praxes/blob/master/setup.py), which might work for ipython as well:

scripts = []
if sys.platform.startswith('win'):
    # scripts calling multiprocessing must be importable
    import shutil
    shutil.copy('scripts/sxfm', 'scripts/sxfm.py')
    scripts.append('scripts/sxfm.py')
else:
    scripts.append('scripts/sxfm')
if ('bdist_wininst' in sys.argv) or ('bdist_msi' in sys.argv):
    scripts.append('scripts/praxes_win_post_install.py')

I guess the extension for ipython-qtconsole should be pyw, so you don't get a dos shell along with the qt console.

@minrk
IPython member

I am totally fine with making setuptools a dependency on Windows if getting the executables to work is more than trivial without it.

@fperez
IPython member
@minrk
IPython member

PR #536 makes setuptools a dependency for install on Windows. Merging that means IPython will not work without setuptools on Windows, because the installed executables in a bdist will also depend on setuptools.

@minrk minrk added a commit that closed this issue Jun 24, 2011
@minrk minrk Merge branch 'winsetup' (PR #536)
introduces install dependency of setuptools on Windows

This is a temporary fix, and the setuptools dependency should
be removed in 0.12.

closes gh-536
closes gh-351
closes gh-369
933e2d9
@minrk minrk closed this in 933e2d9 Jun 24, 2011
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk minrk Merge branch 'winsetup' (PR #536)
introduces install dependency of setuptools on Windows

This is a temporary fix, and the setuptools dependency should
be removed in 0.12.

closes gh-536
closes gh-351
closes gh-369
5d5d81f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment