Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

use argparse instead of kvloader for flags&aliases #563

Closed
minrk opened this Issue · 3 comments

3 participants

Min RK Robert Kern David Warde-Farley
Min RK
Owner

As the new command line args have crept up in functionality, we are now approaching argparse-level code, which is exactly what we wanted to avoid. We should be using argparse for everything in flags&aliases now, and only use the KV loader for explicit Class.trait=value arguments.

The Parsers should be generated from similar data structures to the current Flags&Aliases, and not hand-written.

Robert Kern
Collaborator

+1. Thanks!

David Warde-Farley

+1. The custom argument parsing code leads to some interesting/annoying gotchas in corners not quite explored, e.g. #570.

Min RK
Owner

Closed by PR #674

Min RK minrk closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.