Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

UnicodeDecodeError during startup #569

Closed
jstenar opened this Issue Jul 11, 2011 · 5 comments

Comments

Projects
None yet
3 participants
Member

jstenar commented Jul 11, 2011

If I try to add a files to c.TerminalIPythonApp.exec_files in the config file I get a UnicodeDecodeError on startup if there is a non ascii character in my current path (see https://gist.github.com/1076426).

As far as I can tell it is because there is a call to os.getcwd on line 140 in utils/path.py. The issue goes away by changing to os.getcwdu. (Code on my getcwdu branch)

A search through the codebase reveals another 38 calls to os.getcwd

Owner

minrk commented Jul 11, 2011

I imagine that a bulk find/replace of getcwd => getcwdu should be fine.

Member

jstenar commented Jul 11, 2011

minrk skrev 2011-07-11 23:47:

I imagine that a bulk find/replace of getcwd => getcwdu should be fine.

I can do that and make a pull request. I need the practice :)
But it will have to wait until tomorrow night.

/Jörgen

Member

jstenar commented Jul 12, 2011

I just pushed my search and replace work to the getcwdu branch. I left core/prompts.py alone for now because more changes are need to get it to work. The Itpl code does not work properly with unicode strings.

Owner

minrk commented Jul 13, 2011

Do you want to issue a pull request from the cwdu branch, or is the Itpl fix necessary? I think Thomas was working on removing Itpl, so I'm not sure it's worth updating if it's more than an easy fix. Do you run into real issues resulting from Itpl not working?

Owner

takluyver commented Jul 14, 2011

Closed by PR #574.

@takluyver takluyver closed this Jul 14, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment