Skip to content
This repository

Tests fail if tornado not installed #739

Closed
takluyver opened this Issue · 4 comments

4 participants

Thomas Kluyver Min RK Fernando Perez Brian E. Granger
Thomas Kluyver
Collaborator

Some of the frontend tests seem to depend on tornado. We should use the existing framework to check if it's installed and skip the tests if not.

Fernando Perez
Owner

Totally agreed. Marking as critical for 0.12, b/c the test suite would otherwise bomb for lots of people.

Brian E. Granger
Owner

I am a bit surprised by this as none of the tests should import tornado. But, will nose import all of the modules in the frontend.html.notebook package looking for doctests?

Brian E. Granger
Owner
Min RK
Owner

closed by PR #748

Min RK minrk closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.