Tests fail if tornado not installed #739

Closed
takluyver opened this Issue Aug 27, 2011 · 4 comments

Projects

None yet

4 participants

@takluyver
Member

Some of the frontend tests seem to depend on tornado. We should use the existing framework to check if it's installed and skip the tests if not.

@fperez
Member
fperez commented Aug 27, 2011

Totally agreed. Marking as critical for 0.12, b/c the test suite would otherwise bomb for lots of people.

@ellisonbg
Member

I am a bit surprised by this as none of the tests should import tornado. But, will nose import all of the modules in the frontend.html.notebook package looking for doctests?

@ellisonbg
Member

See PR #748

On Sat, Aug 27, 2011 at 3:05 AM, takluyver
reply@reply.github.com
wrote:

Some of the frontend tests seem to depend on tornado. We should use the existing framework to check if it's installed and skip the tests if not.

Reply to this email directly or view it on GitHub:
#739

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk
Member
minrk commented Sep 9, 2011

closed by PR #748

@minrk minrk closed this Sep 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment