Tests fail if tornado not installed #739

Closed
takluyver opened this Issue Aug 27, 2011 · 4 comments

Comments

Projects
None yet
4 participants
@takluyver
Member

takluyver commented Aug 27, 2011

Some of the frontend tests seem to depend on tornado. We should use the existing framework to check if it's installed and skip the tests if not.

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Aug 27, 2011

Member

Totally agreed. Marking as critical for 0.12, b/c the test suite would otherwise bomb for lots of people.

Member

fperez commented Aug 27, 2011

Totally agreed. Marking as critical for 0.12, b/c the test suite would otherwise bomb for lots of people.

@ellisonbg

This comment has been minimized.

Show comment
Hide comment
@ellisonbg

ellisonbg Aug 29, 2011

Member

I am a bit surprised by this as none of the tests should import tornado. But, will nose import all of the modules in the frontend.html.notebook package looking for doctests?

Member

ellisonbg commented Aug 29, 2011

I am a bit surprised by this as none of the tests should import tornado. But, will nose import all of the modules in the frontend.html.notebook package looking for doctests?

@ellisonbg

This comment has been minimized.

Show comment
Hide comment
@ellisonbg

ellisonbg Aug 30, 2011

Member

See PR #748

On Sat, Aug 27, 2011 at 3:05 AM, takluyver
reply@reply.github.com
wrote:

Some of the frontend tests seem to depend on tornado. We should use the existing framework to check if it's installed and skip the tests if not.

Reply to this email directly or view it on GitHub:
#739

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

Member

ellisonbg commented Aug 30, 2011

See PR #748

On Sat, Aug 27, 2011 at 3:05 AM, takluyver
reply@reply.github.com
wrote:

Some of the frontend tests seem to depend on tornado. We should use the existing framework to check if it's installed and skip the tests if not.

Reply to this email directly or view it on GitHub:
#739

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Sep 9, 2011

Member

closed by PR #748

Member

minrk commented Sep 9, 2011

closed by PR #748

@minrk minrk closed this Sep 9, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment