Ctrl-Enter clears line in notebook #740

Closed
takluyver opened this Issue Aug 27, 2011 · 3 comments

Comments

Projects
None yet
3 participants
@takluyver
Member

takluyver commented Aug 27, 2011

Ctrl-enter should immediately execute the current line, and move to a new line within the new cell, and it does in Chrome. But in Firefox, it seems to clear the current line without executing it, and move to a new line.

Tested in Firefox 6 (Ubuntu), with Tornado from git today.

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Aug 27, 2011

Member

Not quite my experience. Also, there's no new cell, ctrl-Enter is for executing a series of commands in one cell (e.g. ls, cd, etc. things you don't actually want to be part of the notebook).

In Chrome: ctrl-Enter executes the cell, and leaves the input selected, so typing the next command will clear it (this is the correct behavior).
In FF6: ctrl-Enter executes, but clears input and adds a newline, which it shouldn't. It is essentially equivalent to the Chrome behavior followed by hitting 'Enter'.

Member

minrk commented Aug 27, 2011

Not quite my experience. Also, there's no new cell, ctrl-Enter is for executing a series of commands in one cell (e.g. ls, cd, etc. things you don't actually want to be part of the notebook).

In Chrome: ctrl-Enter executes the cell, and leaves the input selected, so typing the next command will clear it (this is the correct behavior).
In FF6: ctrl-Enter executes, but clears input and adds a newline, which it shouldn't. It is essentially equivalent to the Chrome behavior followed by hitting 'Enter'.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Aug 27, 2011

Member

OK, for some reason when I tried it before I didn't think it was executing, but having tried it again, it seems I was wrong about that.

Member

takluyver commented Aug 27, 2011

OK, for some reason when I tried it before I didn't think it was executing, but having tried it again, it seems I was wrong about that.

@ellisonbg

This comment has been minimized.

Show comment
Hide comment
@ellisonbg

ellisonbg Aug 30, 2011

Member

Fixed the behavior in Firefox in master.

On Sat, Aug 27, 2011 at 5:23 AM, takluyver
reply@reply.github.com
wrote:

Ctrl-enter should immediately execute the current line, and move to a new line within the new cell, and it does in Chrome. But in Firefox, it seems to clear the current line without executing it, and move to a new line.

Tested in Firefox 6 (Ubuntu), with Tornado from git today.

Reply to this email directly or view it on GitHub:
#740

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

Member

ellisonbg commented Aug 30, 2011

Fixed the behavior in Firefox in master.

On Sat, Aug 27, 2011 at 5:23 AM, takluyver
reply@reply.github.com
wrote:

Ctrl-enter should immediately execute the current line, and move to a new line within the new cell, and it does in Chrome. But in Firefox, it seems to clear the current line without executing it, and move to a new line.

Tested in Firefox 6 (Ubuntu), with Tornado from git today.

Reply to this email directly or view it on GitHub:
#740

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk minrk closed this Sep 7, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment