Skip to content
This repository

qtconsole ipython widget's execute_file fails if filename contains spaces or quotes #755

Closed
jdmarch opened this Issue September 02, 2011 · 3 comments

3 participants

Jonathan March Min RK Fernando Perez
Jonathan March
Collaborator

(All platforms)

This routine is already a hack, I think only necessary because of remaining issues with backslash handling in Windows, but while it's here, is there any reason not to simply escape any double quotes in the filename (for non-Windows platforms) and wrap the whole thing in double quotes (for all platforms)?

Fernando Perez
Owner

On master, this works for me in both the terminal and the qt console:

In [10]: d a\ b
total 4
-rwxr-xr-x 1 fperez 187 2011-12-06 03:03 argv.py*

In [11]: run a\ b/argv.py
argv: ['a b/argv.py']
My PID is: 5547
my name is: __main__

are you still seeing the problem? If so, on which platforms?

Jonathan March jdmarch referenced this issue from a commit in jdmarch/ipython December 07, 2011
Jonathan March BUG: Issue #755 qt IPythonWidget.execute_file fails if filename conta…
…ins single and double quotes
ebfa946
Jonathan March
Collaborator

Sorry, should have updated this issue after commits.

  1. AFAICT, qtconsole's IPythonWidget.execute_file is not used anywhere in the IPython-qtconsole application. It is available for use in applications which incorporate a qtconsole.

  2. Commits 3ccb8ee and 03159d0 resolved all but an extreme edge case (a filename containing both single and double quotes).

  3. PR #1122 should resolve that final case. Not sure why I was hesitant to make this change originally.

Jonathan March
Collaborator

Making this last fix did reveal what appears to be a very minor bug in %run: issue #1123

Min RK minrk closed this issue from a commit December 12, 2011
Min RK Merge PR #1122 (IPythonWidget.execute_file)
Fixes escaped filename in IPythonWidget.execute_file, when it contains
spaces and/or quotes.

closes #755
closes #1122
b24c9d2
Min RK minrk closed this in b24c9d2 December 12, 2011
Brian E. Granger ellisonbg referenced this issue from a commit January 10, 2012
Commit has since been removed from the repository and is no longer available.
Brian E. Granger ellisonbg referenced this issue from a commit January 10, 2012
Commit has since been removed from the repository and is no longer available.
Brian E. Granger ellisonbg referenced this issue from a commit January 10, 2012
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.